diff options
| author |   Harshad Shirwadkar <harshadshirwadkar@gmail.com> | 2020-11-05 19:59:00 -0800 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2020-11-06 23:01:04 -0500 |
| commit | 0ee66ddcf3c1503a9bdb3e49a7a96c6e429ddfad (patch) | |
| tree | f85916d9b96773c641e3fb00333e43fcfef5d9f8 /fs | |
| parent | jbd2: add todo for a fast commit performance optimization (diff) | |
| download | linux-dev-0ee66ddcf3c1503a9bdb3e49a7a96c6e429ddfad.tar.xz linux-dev-0ee66ddcf3c1503a9bdb3e49a7a96c6e429ddfad.zip | |
jbd2: don't touch buffer state until it is filled
Fast commit buffers should be filled in before toucing their
state. Remove code that sets buffer state as dirty before the buffer
is passed to the file system.
Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201106035911.1942128-12-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/jbd2/journal.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 59166e299cde..b5fbcd1b444c 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -891,11 +891,7 @@ int jbd2_fc_get_buf(journal_t *journal, struct buffer_head **bh_out) if (!bh) return -ENOMEM; - lock_buffer(bh); - clear_buffer_uptodate(bh); - set_buffer_dirty(bh); - unlock_buffer(bh); journal->j_fc_wbuf[fc_off] = bh; *bh_out = bh; |