aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorNicholas Mc Guire <hofrat@osadl.org>2018-08-23 12:24:02 +0200
committerSteve French <stfrench@microsoft.com>2018-08-23 15:10:49 -0500
commit126c97f4d0d1b5b956e8b0740c81a2b2a2ae548c (patch)
tree98db93cba5fa52c99aeb86f1fcbb2111e9346093 /fs
parentcifs: check if SMB2 PDU size has been padded and suppress the warning (diff)
downloadlinux-dev-126c97f4d0d1b5b956e8b0740c81a2b2a2ae548c.tar.xz
linux-dev-126c97f4d0d1b5b956e8b0740c81a2b2a2ae548c.zip
cifs: check kmalloc before use
The kmalloc was not being checked - if it fails issue a warning and return -ENOMEM to the caller. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: b8da344b74c8 ("cifs: dynamic allocation of ntlmssp blob") Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> cc: Stable <stable@vger.kernel.org>`
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/sess.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index 8b0502cd39af..aa23c00367ec 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -398,6 +398,12 @@ int build_ntlmssp_auth_blob(unsigned char **pbuffer,
goto setup_ntlmv2_ret;
}
*pbuffer = kmalloc(size_of_ntlmssp_blob(ses), GFP_KERNEL);
+ if (!*pbuffer) {
+ rc = -ENOMEM;
+ cifs_dbg(VFS, "Error %d during NTLMSSP allocation\n", rc);
+ *buflen = 0;
+ goto setup_ntlmv2_ret;
+ }
sec_blob = (AUTHENTICATE_MESSAGE *)*pbuffer;
memcpy(sec_blob->Signature, NTLMSSP_SIGNATURE, 8);