diff options
| author |   Namjae Jeon <linkinjeon@kernel.org> | 2021-11-24 10:23:02 +0900 |
|---|---|---|
| committer |   Steve French <stfrench@microsoft.com> | 2021-11-25 00:09:26 -0600 |
| commit | 178ca6f85aa3231094467691f5ea1ff2f398aa8d (patch) | |
| tree | d49c70b0b3fdabd2582ece19668132e9d8c89ea3 /fs | |
| parent | ksmbd: contain default data stream even if xattr is empty (diff) | |
| download | linux-dev-178ca6f85aa3231094467691f5ea1ff2f398aa8d.tar.xz linux-dev-178ca6f85aa3231094467691f5ea1ff2f398aa8d.zip | |
ksmbd: fix memleak in get_file_stream_info()
Fix memleak in get_file_stream_info()
Fixes: 34061d6b76a4 ("ksmbd: validate OutputBufferLength of QUERY_DIR, QUERY_INFO, IOCTL requests")
Cc: stable@vger.kernel.org # v5.15
Reported-by: Coverity Scan <scan-admin@coverity.com>
Acked-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ksmbd/smb2pdu.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c index 370a32b93087..49c9da37315c 100644 --- a/fs/ksmbd/smb2pdu.c +++ b/fs/ksmbd/smb2pdu.c @@ -4498,8 +4498,10 @@ static void get_file_stream_info(struct ksmbd_work *work, ":%s", &stream_name[XATTR_NAME_STREAM_LEN]); next = sizeof(struct smb2_file_stream_info) + streamlen * 2; - if (next > buf_free_len) + if (next > buf_free_len) { + kfree(stream_buf); break; + } file_info = (struct smb2_file_stream_info *)&rsp->Buffer[nbytes]; streamlen = smbConvertToUTF16((__le16 *)file_info->StreamName, |