diff options
| author |   Darrick J. Wong <darrick.wong@oracle.com> | 2016-10-10 16:49:29 +1100 |
|---|---|---|
| committer |   Dave Chinner <david@fromorbit.com> | 2016-10-10 16:49:29 +1100 |
| commit | 1987fd743415564e8c67f2f7ec0ae3c18a6b11cd (patch) | |
| tree | 90cefba2ca90369248f60518808ab14b7dcd27be /fs | |
| parent | xfs: fix error initialization (diff) | |
| download | linux-dev-1987fd743415564e8c67f2f7ec0ae3c18a6b11cd.tar.xz linux-dev-1987fd743415564e8c67f2f7ec0ae3c18a6b11cd.zip | |
xfs: clear reflink flag if setting realtime flag
Since we can only turn on the rt flag if there are no data extents,
we can safely turn off the reflink flag if the rt flag is being
turned on.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reported-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 8b9f31c54c1e..598b97bb19da 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1034,9 +1034,9 @@ xfs_ioctl_setattr_xflags( return -EINVAL; } - /* Don't allow us to set realtime mode for a reflinked file. */ + /* Clear reflink if we are actually able to set the rt flag. */ if ((fa->fsx_xflags & FS_XFLAG_REALTIME) && xfs_is_reflink_inode(ip)) - return -EINVAL; + ip->i_d.di_flags2 &= ~XFS_DIFLAG2_REFLINK; /* Don't allow us to set DAX mode for a reflinked file for now. */ if ((fa->fsx_xflags & FS_XFLAG_DAX) && xfs_is_reflink_inode(ip)) |