diff options
| author |   Chuhong Yuan <hslester96@gmail.com> | 2019-10-14 15:15:31 +0800 |
|---|---|---|
| committer |   Steve French <stfrench@microsoft.com> | 2019-10-20 19:19:49 -0500 |
| commit | 783bf7b8b641167fb6f3f4f787f60ae62bad41b3 (patch) | |
| tree | de3a1a39e64fad913b677c3b7a7517add2b0639f /fs | |
| parent | CIFS: avoid using MID 0xFFFF (diff) | |
| download | linux-dev-783bf7b8b641167fb6f3f4f787f60ae62bad41b3.tar.xz linux-dev-783bf7b8b641167fb6f3f4f787f60ae62bad41b3.zip | |
cifs: Fix missed free operations
cifs_setattr_nounix has two paths which miss free operations
for xid and fullpath.
Use goto cifs_setattr_exit like other paths to fix them.
CC: Stable <stable@vger.kernel.org>
Fixes: aa081859b10c ("cifs: flush before set-info if we have writeable handles")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 5dcc95b38310..df9377828e2f 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2475,9 +2475,9 @@ cifs_setattr_nounix(struct dentry *direntry, struct iattr *attrs) rc = tcon->ses->server->ops->flush(xid, tcon, &wfile->fid); cifsFileInfo_put(wfile); if (rc) - return rc; + goto cifs_setattr_exit; } else if (rc != -EBADF) - return rc; + goto cifs_setattr_exit; else rc = 0; } |