diff options
| author |   Jonathan Cameron <jic23@cam.ac.uk> | 2011-04-19 12:43:46 +0100 |
|---|---|---|
| committer |   Rusty Russell <rusty@rustcorp.com.au> | 2011-05-19 16:55:28 +0930 |
| commit | a0374396375d06398c419ebb6857fb5809cff81f (patch) | |
| tree | 3c756c3cfd61e2ea4323d07fc208d0e6528ad3a1 /fs | |
| parent | Add a strtobool function matching semantics of existing in kernel equivalents (diff) | |
| download | linux-dev-a0374396375d06398c419ebb6857fb5809cff81f.tar.xz linux-dev-a0374396375d06398c419ebb6857fb5809cff81f.zip | |
debugfs: move to new strtobool
No functional changes requires that we eat errors from strtobool.
If people want to not do this, then it should be fixed at a later date.
V2: Simplification suggested by Rusty Russell removes the need for
additional variable ret.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/debugfs/file.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 89d394d8fe24..568304d058a3 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -429,25 +429,16 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf, { char buf[32]; int buf_size; + bool bv; u32 *val = file->private_data; buf_size = min(count, (sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; - switch (buf[0]) { - case 'y': - case 'Y': - case '1': - *val = 1; - break; - case 'n': - case 'N': - case '0': - *val = 0; - break; - } - + if (strtobool(buf, &bv) == 0) + *val = bv; + return count; } |