diff options
| author |   Liu Bo <bo.li.liu@oracle.com> | 2017-04-10 12:36:26 -0700 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2017-04-11 18:49:56 +0200 |
| commit | a967efb30b3afa3d858edd6a17f544f9e9e46eea (patch) | |
| tree | 86b2f9e56b32934fc56b46148feb8509cf72c81b /fs | |
| parent | Btrfs: fix segmentation fault when doing dio read (diff) | |
| download | linux-dev-a967efb30b3afa3d858edd6a17f544f9e9e46eea.tar.xz linux-dev-a967efb30b3afa3d858edd6a17f544f9e9e46eea.zip | |
Btrfs: fix potential use-after-free for cloned bio
KASAN reports that there is a use-after-free case of bio in btrfs_map_bio.
If we need to submit IOs to several disks at a time, the original bio
would get cloned and mapped to the destination disk, but we really should
use the original bio instead of a cloned bio to do the sanity check
because cloned bios are likely to be freed by its endio.
Reported-by: Diego <diegocg@gmail.com>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/volumes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 7c8c7bbee197..7c7e0c99360f 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -6213,7 +6213,7 @@ int btrfs_map_bio(struct btrfs_fs_info *fs_info, struct bio *bio, for (dev_nr = 0; dev_nr < total_devs; dev_nr++) { dev = bbio->stripes[dev_nr].dev; if (!dev || !dev->bdev || - (bio_op(bio) == REQ_OP_WRITE && !dev->writeable)) { + (bio_op(first_bio) == REQ_OP_WRITE && !dev->writeable)) { bbio_error(bbio, first_bio, logical); continue; } |