diff options
| author |   J. R. Okajima <hooanon05@yahoo.co.jp> | 2009-06-17 01:16:50 +0900 |
|---|---|---|
| committer |   Al Viro <viro@zeniv.linux.org.uk> | 2009-06-17 00:36:35 -0400 |
| commit | b0895513f499b8f786d292ce48589ca210ca1d6e (patch) | |
| tree | e7e7e684f19a930ca029afa08396aa5170e7fb3d /fs | |
| parent | ext4: avoid unnecessary spinlock in critical POSIX ACL path (diff) | |
| download | linux-dev-b0895513f499b8f786d292ce48589ca210ca1d6e.tar.xz linux-dev-b0895513f499b8f786d292ce48589ca210ca1d6e.zip | |
remove unlock_kernel() left accidentally
commit 337eb00a2c3a421999c39c94ce7e33545ee8baa7
Push BKL down into ->remount_fs()
and
commit 4aa98cf768b6f2ea4b204620d949a665959214f6
Push BKL down into do_remount_sb()
were uncorrectly merged.
The former removes one pair of lock/unlock_kernel(), but the latter adds
several unlock_kernel(). Finally a few unlock_kernel() calls left.
Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/super.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/fs/super.c b/fs/super.c index 83b47416d006..d40d53a22fb5 100644 --- a/fs/super.c +++ b/fs/super.c @@ -545,24 +545,18 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) if ((flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY)) { if (force) mark_files_ro(sb); - else if (!fs_may_remount_ro(sb)) { - unlock_kernel(); + else if (!fs_may_remount_ro(sb)) return -EBUSY; - } retval = vfs_dq_off(sb, 1); - if (retval < 0 && retval != -ENOSYS) { - unlock_kernel(); + if (retval < 0 && retval != -ENOSYS) return -EBUSY; - } } remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY); if (sb->s_op->remount_fs) { retval = sb->s_op->remount_fs(sb, &flags, data); - if (retval) { - unlock_kernel(); + if (retval) return retval; - } } sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); if (remount_rw) |