diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-10-30 14:46:20 +0300 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2020-11-06 22:52:36 -0500 |
| commit | e121bd48b9eb8e3b9104d3d5d08fdf88e9ca0f97 (patch) | |
| tree | ef0435d55fef1f399dabd3e54ff1b8ccacea13e2 /fs | |
| parent | MAINTAINERS: add missing file in ext4 entry (diff) | |
| download | linux-dev-e121bd48b9eb8e3b9104d3d5d08fdf88e9ca0f97.tar.xz linux-dev-e121bd48b9eb8e3b9104d3d5d08fdf88e9ca0f97.zip | |
ext4: silence an uninitialized variable warning
Smatch complains that "i" can be uninitialized if we don't enter the
loop. I don't know if it's possible but we may as well silence this
warning.
[ Initialize i to sb->s_blocksize instead of 0. The only way the for
loop could be skipped entirely is the in-memory data structures, in
particular the bh->b_data for the on-disk superblock has gotten
corrupted enough that calculated value of group is >= to
ext4_get_groups_count(sb). In that case, we want to exit
immediately without allocating a block. -- TYT ]
Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201030114620.GB3251003@mwanda
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext4/mballoc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 85abbfb98cbe..f067e83f149e 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5167,7 +5167,7 @@ static ext4_fsblk_t ext4_mb_new_blocks_simple(handle_t *handle, struct super_block *sb = ar->inode->i_sb; ext4_group_t group; ext4_grpblk_t blkoff; - int i; + int i = sb->s_blocksize; ext4_fsblk_t goal, block; struct ext4_super_block *es = EXT4_SB(sb)->s_es; |