diff options
| author |   Jens Axboe <axboe@kernel.dk> | 2019-12-17 19:45:06 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-12-17 19:57:27 -0700 |
| commit | e781573e2fb1b75acdba61dcb9bcbfc16f288442 (patch) | |
| tree | 9ff80332eeb57648555db40fa7d43b02b2fa95a9 /fs | |
| parent | io_uring: read opcode and user_data from SQE exactly once (diff) | |
| download | linux-dev-e781573e2fb1b75acdba61dcb9bcbfc16f288442.tar.xz linux-dev-e781573e2fb1b75acdba61dcb9bcbfc16f288442.zip | |
io_uring: warn about unhandled opcode
Now that we have all the opcodes handled in terms of command prep and
SQE reuse, add a printk_once() to warn about any potentially new and
unhandled ones.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/io_uring.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index e0fc195d0d2d..1d4e7332ccae 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3079,9 +3079,11 @@ static int io_req_defer_prep(struct io_kiocb *req) struct iovec inline_vecs[UIO_FASTIOV], *iovec = inline_vecs; struct io_async_ctx *io = req->io; struct iov_iter iter; - ssize_t ret; + ssize_t ret = 0; switch (req->opcode) { + case IORING_OP_NOP: + break; case IORING_OP_READV: case IORING_OP_READ_FIXED: /* ensure prep does right import */ @@ -3141,7 +3143,9 @@ static int io_req_defer_prep(struct io_kiocb *req) ret = io_accept_prep(req); break; default: - ret = 0; + printk_once(KERN_WARNING "io_uring: unhandled opcode %d\n", + req->opcode); + ret = -EINVAL; break; } |