diff options
| author |   Filipe Manana <fdmanana@suse.com> | 2018-11-14 11:35:24 +0000 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2018-11-14 18:26:20 +0100 |
| commit | f505754fd6599230371cb01b9332754ddc104be1 (patch) | |
| tree | 10539af0a48a44d8c861809bb1ea957e3599df4b /fs | |
| parent | Btrfs: fix rare chances for data loss when doing a fast fsync (diff) | |
| download | linux-dev-f505754fd6599230371cb01b9332754ddc104be1.tar.xz linux-dev-f505754fd6599230371cb01b9332754ddc104be1.zip | |
Btrfs: ensure path name is null terminated at btrfs_control_ioctl
We were using the path name received from user space without checking that
it is null terminated. While btrfs-progs is well behaved and does proper
validation and null termination, someone could call the ioctl and pass
a non-null terminated patch, leading to buffer overrun problems in the
kernel. The ioctl is protected by CAP_SYS_ADMIN.
So just set the last byte of the path to a null character, similar to what
we do in other ioctls (add/remove/resize device, snapshot creation, etc).
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index cbc9d0d2c12d..645fc81e2a94 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2237,6 +2237,7 @@ static long btrfs_control_ioctl(struct file *file, unsigned int cmd, vol = memdup_user((void __user *)arg, sizeof(*vol)); if (IS_ERR(vol)) return PTR_ERR(vol); + vol->name[BTRFS_PATH_NAME_MAX] = '\0'; switch (cmd) { case BTRFS_IOC_SCAN_DEV: |