diff options
| author |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-09-10 22:39:22 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-09-11 09:18:26 +0200 |
| commit | c86fb9d997428e0d55ab5a47488b6ba3bc4b5c5b (patch) | |
| tree | 417d55fc1e4d6024bc3467d5869f1e20ff2d6d73 /include/drm | |
| parent | drm/core: Do not call drm_framebuffer_remove internally during teardown. (diff) | |
| download | linux-dev-c86fb9d997428e0d55ab5a47488b6ba3bc4b5c5b.tar.xz linux-dev-c86fb9d997428e0d55ab5a47488b6ba3bc4b5c5b.zip | |
drm: Nuke drm_framebuffer->helper_private
It's completely unused and there's really no reason for this:
- drm_framebuffer structures are invariant after creation, no need for
helpers to manipulate them.
- drm_framebuffer structures should just be embedded (and that's what
all the drivers do).
Stumbled over this since some folks are apparently concerned with the
overhead of struct drm_framebuffer and this is an easy 8 byte saving.
More could be gained by ditching the legacy fields and recomputing
stuff from the fourcc value. But that would require some drm-wide
cocci and real justification.
Cc: gary.k.smith@intel.com
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'include/drm')
| -rw-r--r-- | include/drm/drm_crtc.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 75f49c1ef8bb..c0366e9152e2 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -210,8 +210,6 @@ struct drm_framebuffer { int flags; uint32_t pixel_format; /* fourcc format */ struct list_head filp_head; - /* if you are using the helper */ - void *helper_private; }; struct drm_property_blob { |