diff options
| author |   Tejun Heo <tj@kernel.org> | 2019-10-24 12:03:51 -0700 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2019-10-25 05:56:28 -0700 |
| commit | 5153faac18d293fc7abb19ff7034683fbcd82dc7 (patch) | |
| tree | 485462f8daa9a37a6c5e6f8f70f2f4abcaa38099 /include/linux/cgroup.h | |
| parent | cgroup: pids: use atomic64_t for pids->limit (diff) | |
| download | linux-dev-5153faac18d293fc7abb19ff7034683fbcd82dc7.tar.xz linux-dev-5153faac18d293fc7abb19ff7034683fbcd82dc7.zip | |
cgroup: remove cgroup_enable_task_cg_lists() optimization
cgroup_enable_task_cg_lists() is used to lazyily initialize task
cgroup associations on the first use to reduce fork / exit overheads
on systems which don't use cgroup. Unfortunately, locking around it
has never been actually correct and its value is dubious given how the
vast majority of systems use cgroup right away from boot.
This patch removes the optimization. For now, replace the cg_list
based branches with WARN_ON_ONCE()'s to be on the safe side. We can
simplify the logic further in the future.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/linux/cgroup.h')
| -rw-r--r-- | include/linux/cgroup.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 3ba3e6da13a6..f6b048902d6c 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -150,7 +150,6 @@ struct task_struct *cgroup_taskset_first(struct cgroup_taskset *tset, struct task_struct *cgroup_taskset_next(struct cgroup_taskset *tset, struct cgroup_subsys_state **dst_cssp); -void cgroup_enable_task_cg_lists(void); void css_task_iter_start(struct cgroup_subsys_state *css, unsigned int flags, struct css_task_iter *it); struct task_struct *css_task_iter_next(struct css_task_iter *it); |