diff options
| author |   Roman Gushchin <guro@fb.com> | 2019-04-26 10:59:45 -0700 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2019-05-06 08:39:11 -0700 |
| commit | 96b9c592def5d7203bdad1337d9c92a2183de5cb (patch) | |
| tree | e7e9f4f31aa3c2182de25d660aba59cf3325d4cd /include/linux/cgroup.h | |
| parent | cgroup: prevent spurious transition into non-frozen state (diff) | |
| download | linux-dev-96b9c592def5d7203bdad1337d9c92a2183de5cb.tar.xz linux-dev-96b9c592def5d7203bdad1337d9c92a2183de5cb.zip | |
cgroup: get rid of cgroup_freezer_frozen_exit()
A task should never enter the exit path with the task->frozen bit set.
Any frozen task must enter the signal handling loop and the only
way to escape is through cgroup_leave_frozen(true), which
unconditionally drops the task->frozen bit. So it means that
cgroyp_freezer_frozen_exit() has zero chances to be called and
has to be removed.
Let's put a WARN_ON_ONCE() instead of the cgroup_freezer_frozen_exit()
call to catch any potential leak of the task's frozen bit.
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Roman Gushchin <guro@fb.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/linux/cgroup.h')
| -rw-r--r-- | include/linux/cgroup.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 3e2efd412dfa..c0077adeea83 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -889,7 +889,7 @@ void cgroup_update_frozen(struct cgroup *cgrp); void cgroup_freeze(struct cgroup *cgrp, bool freeze); void cgroup_freezer_migrate_task(struct task_struct *task, struct cgroup *src, struct cgroup *dst); -void cgroup_freezer_frozen_exit(struct task_struct *task); + static inline bool cgroup_task_freeze(struct task_struct *task) { bool ret; |