diff options
| author |   Ard Biesheuvel <ardb@kernel.org> | 2021-06-10 08:21:50 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2021-06-17 15:07:31 +0800 |
| commit | 22ca9f4aaf431a9413dcc115dd590123307f274f (patch) | |
| tree | b040bedbf50bef3dd355a5588c1de79651625460 /include/linux/crypto.h | |
| parent | crypto: ccp - Use list_move_tail instead of list_del/list_add_tail in ccp-dmaengine.c (diff) | |
| download | linux-dev-22ca9f4aaf431a9413dcc115dd590123307f274f.tar.xz linux-dev-22ca9f4aaf431a9413dcc115dd590123307f274f.zip | |
crypto: shash - avoid comparing pointers to exported functions under CFI
crypto_shash_alg_has_setkey() is implemented by testing whether the
.setkey() member of a struct shash_alg points to the default version,
called shash_no_setkey(). As crypto_shash_alg_has_setkey() is a static
inline, this requires shash_no_setkey() to be exported to modules.
Unfortunately, when building with CFI, function pointers are routed
via CFI stubs which are private to each module (or to the kernel proper)
and so this function pointer comparison may fail spuriously.
Let's fix this by turning crypto_shash_alg_has_setkey() into an out of
line function.
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'include/linux/crypto.h')
0 files changed, 0 insertions, 0 deletions