diff options
| author |   Akinobu Mita <akinobu.mita@gmail.com> | 2011-06-01 23:34:04 +0900 |
|---|---|---|
| committer |   Jan Kara <jack@suse.cz> | 2011-06-25 17:29:52 +0200 |
| commit | 9008593017069ad513cc7dc78a6c94e8dfddba31 (patch) | |
| tree | b44a9c8d3135ebd82fcbe11e0a67a000aa3085aa /include/linux/ext3_fs.h | |
| parent | ext2: include fs.h into ext2_fs.h (diff) | |
| download | linux-dev-9008593017069ad513cc7dc78a6c94e8dfddba31.tar.xz linux-dev-9008593017069ad513cc7dc78a6c94e8dfddba31.zip | |
ext3: use proper little-endian bitops
ext3_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le()
for ext3. But all ext3_{set,clear}_bit() calls ignore return values.
So these can be replaced with __{set,clear}_bit_le().
This changes ext3_{set,clear}_bit safely, because if someone uses
these macros without noticing the change, new ext3_{set,clear}_bit
don't have return value and causes compiler errors where the return
value is used.
This also removes unused ext3_find_first_zero_bit().
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'include/linux/ext3_fs.h')
| -rw-r--r-- | include/linux/ext3_fs.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h index 9aaa3a84d373..8f1f908eddb8 100644 --- a/include/linux/ext3_fs.h +++ b/include/linux/ext3_fs.h @@ -418,12 +418,11 @@ struct ext3_inode { #define EXT2_MOUNT_DATA_FLAGS EXT3_MOUNT_DATA_FLAGS #endif -#define ext3_set_bit __test_and_set_bit_le +#define ext3_set_bit __set_bit_le #define ext3_set_bit_atomic ext2_set_bit_atomic -#define ext3_clear_bit __test_and_clear_bit_le +#define ext3_clear_bit __clear_bit_le #define ext3_clear_bit_atomic ext2_clear_bit_atomic #define ext3_test_bit test_bit_le -#define ext3_find_first_zero_bit find_first_zero_bit_le #define ext3_find_next_zero_bit find_next_zero_bit_le /* |