diff options
| author |   Miklos Szeredi <mszeredi@redhat.com> | 2016-08-03 13:44:27 +0200 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2016-08-03 13:57:56 +0200 |
| commit | c1892c37769cf89c7e7ba57528ae2ccb5d153c9b (patch) | |
| tree | 47ce773ce58dd4f584ba8baffce973b9d55a1148 /include/linux/fs.h | |
| parent | Linux 4.7 (diff) | |
| download | linux-dev-c1892c37769cf89c7e7ba57528ae2ccb5d153c9b.tar.xz linux-dev-c1892c37769cf89c7e7ba57528ae2ccb5d153c9b.zip | |
vfs: fix deadlock in file_remove_privs() on overlayfs
file_remove_privs() is called with inode lock on file_inode(), which
proceeds to calling notify_change() on file->f_path.dentry. Which triggers
the WARN_ON_ONCE(!inode_is_locked(inode)) in addition to deadlocking later
when ovl_setattr tries to lock the underlying inode again.
Fix this mess by not mixing the layers, but doing everything on underlying
dentry/inode.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to overlay inode")
Cc: <stable@vger.kernel.org>
Diffstat (limited to 'include/linux/fs.h')
0 files changed, 0 insertions, 0 deletions