diff options
| author |   Jan Kara <jack@suse.cz> | 2017-02-02 15:56:49 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@fb.com> | 2017-02-02 08:18:41 -0700 |
| commit | f44f1ab5a2dcd4e16eab850fd08e40ff2d0c28d4 (patch) | |
| tree | 759fa3fdce7ef3b945baa2668842c5216e42bf1f /include/linux/fs.h | |
| parent | nbd: use an idr to keep track of nbd devices (diff) | |
| download | linux-dev-f44f1ab5a2dcd4e16eab850fd08e40ff2d0c28d4.tar.xz linux-dev-f44f1ab5a2dcd4e16eab850fd08e40ff2d0c28d4.zip | |
block: Unhash block device inodes on gendisk destruction
Currently, block device inodes stay around after corresponding gendisk
hash died until memory reclaim finds them and frees them. Since we will
make block device inode pin the bdi, we want to free the block device
inode as soon as the device goes away so that bdi does not stay around
unnecessarily. Furthermore we need to avoid issues when new device with
the same major,minor pair gets created since reusing the bdi structure
would be rather difficult in this case.
Unhashing block device inode on gendisk destruction nicely deals with
these problems. Once last block device inode reference is dropped (which
may be directly in del_gendisk()), the inode gets evicted. Furthermore if
the major,minor pair gets reallocated, we are guaranteed to get new
block device inode even if old block device inode is not yet evicted and
thus we avoid issues with possible reuse of bdi.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'include/linux/fs.h')
| -rw-r--r-- | include/linux/fs.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h index 2ba074328894..702cb6c50194 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2342,6 +2342,7 @@ extern struct kmem_cache *names_cachep; #ifdef CONFIG_BLOCK extern int register_blkdev(unsigned int, const char *); extern void unregister_blkdev(unsigned int, const char *); +extern void bdev_unhash_inode(dev_t dev); extern struct block_device *bdget(dev_t); extern struct block_device *bdgrab(struct block_device *bdev); extern void bd_set_size(struct block_device *, loff_t size); |