diff options
| author |   Tejun Heo <tj@kernel.org> | 2019-11-04 15:54:30 -0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2019-11-12 08:18:04 -0800 |
| commit | fe0f726c9fb626b1092a9ea3bf75f57f2eed676e (patch) | |
| tree | 5e0b0f747fee61ed6a9f05558419a029eed59d79 /include/linux/kernfs.h | |
| parent | kernfs: convert kernfs_node->id from union kernfs_node_id to u64 (diff) | |
| download | linux-dev-fe0f726c9fb626b1092a9ea3bf75f57f2eed676e.tar.xz linux-dev-fe0f726c9fb626b1092a9ea3bf75f57f2eed676e.zip | |
kernfs: combine ino/id lookup functions into kernfs_find_and_get_node_by_id()
kernfs_find_and_get_node_by_ino() looks the kernfs_node matching the
specified ino. On top of that, kernfs_get_node_by_id() and
kernfs_fh_get_inode() implement full ID matching by testing the rest
of ID.
On surface, confusingly, the two are slightly different in that the
latter uses 0 gen as wildcard while the former doesn't - does it mean
that the latter can't uniquely identify inodes w/ 0 gen? In practice,
this is a distinction without a difference because generation number
starts at 1. There are no actual IDs with 0 gen, so it can always
safely used as wildcard.
Let's simplify the code by renaming kernfs_find_and_get_node_by_ino()
to kernfs_find_and_get_node_by_id(), moving all lookup logics into it,
and removing now unnecessary kernfs_get_node_by_id().
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/kernfs.h')
| -rw-r--r-- | include/linux/kernfs.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h index b2fc5c8ef6d9..38267cc9420c 100644 --- a/include/linux/kernfs.h +++ b/include/linux/kernfs.h @@ -393,7 +393,8 @@ void kernfs_kill_sb(struct super_block *sb); void kernfs_init(void); -struct kernfs_node *kernfs_get_node_by_id(struct kernfs_root *root, u64 id); +struct kernfs_node *kernfs_find_and_get_node_by_id(struct kernfs_root *root, + u64 id); #else /* CONFIG_KERNFS */ static inline enum kernfs_node_type kernfs_type(struct kernfs_node *kn) |