diff options
| author |   Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2019-02-12 17:25:54 +0100 |
|---|---|---|
| committer |   Thomas Gleixner <tglx@linutronix.de> | 2019-02-28 11:18:38 +0100 |
| commit | ad01423aedaa7c6dd62d560b73a3cb39e6da3901 (patch) | |
| tree | 0c63d73a349d8c51b3de8b71440de07564a38221 /include/linux/kthread.h | |
| parent | kthread: Convert worker lock to raw spinlock (diff) | |
| download | linux-dev-ad01423aedaa7c6dd62d560b73a3cb39e6da3901.tar.xz linux-dev-ad01423aedaa7c6dd62d560b73a3cb39e6da3901.zip | |
kthread: Do not use TIMER_IRQSAFE
The TIMER_IRQSAFE usage was introduced in commit 22597dc3d97b1 ("kthread:
initial support for delayed kthread work") which modelled the delayed
kthread code after workqueue's code. The workqueue code requires the flag
TIMER_IRQSAFE for synchronisation purpose. This is not true for kthread's
delay timer since all operations occur under a lock.
Remove TIMER_IRQSAFE from the timer initialisation and use timer_setup()
for initialisation purpose which is the official function.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lkml.kernel.org/r/20190212162554.19779-2-bigeasy@linutronix.de
Diffstat (limited to 'include/linux/kthread.h')
| -rw-r--r-- | include/linux/kthread.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/include/linux/kthread.h b/include/linux/kthread.h index 6b8c064f0cbc..3d9d834c66a2 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h @@ -164,9 +164,8 @@ extern void __kthread_init_worker(struct kthread_worker *worker, #define kthread_init_delayed_work(dwork, fn) \ do { \ kthread_init_work(&(dwork)->work, (fn)); \ - __init_timer(&(dwork)->timer, \ - kthread_delayed_work_timer_fn, \ - TIMER_IRQSAFE); \ + timer_setup(&(dwork)->timer, \ + kthread_delayed_work_timer_fn, 0); \ } while (0) int kthread_worker_fn(void *worker_ptr); |