diff options
| author |   Johannes Berg <johannes.berg@intel.com> | 2021-09-15 18:16:01 +0200 |
|---|---|---|
| committer |   Pavel Machek <pavel@ucw.cz> | 2021-09-27 16:16:42 +0200 |
| commit | 2a5a8fa8b23144d14567d6f8293dd6fbeecee393 (patch) | |
| tree | cfbcb7cb2c23665ecc400bac2cc29d21f4fe40b5 /include/linux/leds.h | |
| parent | led-class-flash: fix -Wrestrict warning (diff) | |
| download | linux-dev-2a5a8fa8b23144d14567d6f8293dd6fbeecee393.tar.xz linux-dev-2a5a8fa8b23144d14567d6f8293dd6fbeecee393.zip | |
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'include/linux/leds.h')
| -rw-r--r-- | include/linux/leds.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/leds.h b/include/linux/leds.h index a0b730be40ad..ba4861ec73d3 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -360,7 +360,7 @@ struct led_trigger { struct led_hw_trigger_type *trigger_type; /* LEDs under control by this trigger (for simple triggers) */ - rwlock_t leddev_list_lock; + spinlock_t leddev_list_lock; struct list_head led_cdevs; /* Link to next registered trigger */ |