diff options
| author |   Mateusz Jończyk <mat.jonczyk@o2.pl> | 2021-12-10 21:01:27 +0100 |
|---|---|---|
| committer |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2021-12-16 21:50:06 +0100 |
| commit | ec5895c0f2d87b9bf4185db1915e40fa6fcfc0ac (patch) | |
| tree | 59f2419c3ad7ba247b0589ed7ed62dd7ac81f64d /include/linux/mc146818rtc.h | |
| parent | rtc: mc146818-lib: fix RTC presence check (diff) | |
| download | linux-dev-ec5895c0f2d87b9bf4185db1915e40fa6fcfc0ac.tar.xz linux-dev-ec5895c0f2d87b9bf4185db1915e40fa6fcfc0ac.zip | |
rtc: mc146818-lib: extract mc146818_avoid_UIP
Function mc146818_get_time() contains an elaborate mechanism of reading
the RTC time while no RTC update is in progress. It turns out that
reading the RTC alarm clock also requires avoiding the RTC update.
Therefore, the mechanism in mc146818_get_time() should be reused - so
extract it into a separate function.
The logic in mc146818_avoid_UIP() is same as in mc146818_get_time()
except that after every
if (CMOS_READ(RTC_FREQ_SELECT) & RTC_UIP) {
there is now "mdelay(1)".
To avoid producing a very unreadable patch, mc146818_get_time() will be
refactored to use mc146818_avoid_UIP() in the next patch.
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211210200131.153887-6-mat.jonczyk@o2.pl
Diffstat (limited to 'include/linux/mc146818rtc.h')
| -rw-r--r-- | include/linux/mc146818rtc.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h index 69c80c4325bf..67fb0a12becc 100644 --- a/include/linux/mc146818rtc.h +++ b/include/linux/mc146818rtc.h @@ -127,4 +127,7 @@ bool mc146818_does_rtc_work(void); unsigned int mc146818_get_time(struct rtc_time *time); int mc146818_set_time(struct rtc_time *time); +bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param), + void *param); + #endif /* _MC146818RTC_H */ |