diff options
| author |   Vladimir Davydov <vdavydov@parallels.com> | 2014-01-23 15:52:55 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-23 16:36:50 -0800 |
| commit | 3965fc3652244651006ebb31c8c45318ce84818f (patch) | |
| tree | 6ab0e736387b7694d874809ff4b8e9b463461f28 /include/linux/memcontrol.h | |
| parent | mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE (diff) | |
| download | linux-dev-3965fc3652244651006ebb31c8c45318ce84818f.tar.xz linux-dev-3965fc3652244651006ebb31c8c45318ce84818f.zip | |
slab: clean up kmem_cache_create_memcg() error handling
Currently kmem_cache_create_memcg() backoffs on failure inside
conditionals, without using gotos. This results in the rollback code
duplication, which makes the function look cumbersome even though on
error we should only free the allocated cache. Since in the next patch
I am going to add yet another rollback function call on error path
there, let's employ labels instead of conditionals for undoing any
changes on failure to keep things clean.
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Glauber Costa <glommer@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Christoph Lameter <cl@linux.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/memcontrol.h')
0 files changed, 0 insertions, 0 deletions