diff options
| author |   Lars-Peter Clausen <lars@metafoo.de> | 2009-10-14 02:12:33 +0400 |
|---|---|---|
| committer |   Samuel Ortiz <sameo@linux.intel.com> | 2009-12-13 19:21:17 +0100 |
| commit | 68d641efd86d901d000b888eeab5481257d49f12 (patch) | |
| tree | a916769e71d50c0d20725cad60fb0402da198692 /include/linux/mfd/pcf50633 | |
| parent | mfd: Move pcf50633 messages to appropriate log levels (diff) | |
| download | linux-dev-68d641efd86d901d000b888eeab5481257d49f12.tar.xz linux-dev-68d641efd86d901d000b888eeab5481257d49f12.zip | |
mfd: Fix memleak in pcf50633_client_dev_register
Since platform_device_add_data copies the passed data, the allocated
subdev_pdata is never freed. A simple fix would be to either free subdev_pdata
or put it onto the stack. But since the pcf50633 child devices can rely on
beeing children of the pcf50633 core device it's much more elegant to get access
to pcf50633 core structure through that link. This allows to get completly rid
of pcf5033_subdev_pdata.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'include/linux/mfd/pcf50633')
| -rw-r--r-- | include/linux/mfd/pcf50633/core.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/include/linux/mfd/pcf50633/core.h b/include/linux/mfd/pcf50633/core.h index 9aba7b779fbc..d9034cc87f18 100644 --- a/include/linux/mfd/pcf50633/core.h +++ b/include/linux/mfd/pcf50633/core.h @@ -40,10 +40,6 @@ struct pcf50633_platform_data { u8 resumers[5]; }; -struct pcf50633_subdev_pdata { - struct pcf50633 *pcf; -}; - struct pcf50633_irq { void (*handler) (int, void *); void *data; @@ -217,5 +213,9 @@ enum pcf50633_reg_int5 { #define PCF50633_REG_LEDCTL 0x2a #define PCF50633_REG_LEDDIM 0x2b -#endif +static inline struct pcf50633 *dev_to_pcf50633(struct device *dev) +{ + return dev_get_drvdata(dev); +} +#endif |