diff options
| author |   Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2017-01-10 16:58:00 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2017-01-10 18:31:55 -0800 |
| commit | f073bdc51771f5a5c7a8d1191bfc3ae371d44de7 (patch) | |
| tree | 028dad6c091084d148f4b6ea4634ba31235b55bc /include/linux/mm_inline.h | |
| parent | mailmap: add codeaurora.org names for nameless email commits (diff) | |
| download | linux-dev-f073bdc51771f5a5c7a8d1191bfc3ae371d44de7.tar.xz linux-dev-f073bdc51771f5a5c7a8d1191bfc3ae371d44de7.zip | |
mm: don't dereference struct page fields of invalid pages
The VM_BUG_ON() check in move_freepages() checks whether the node id of
a page matches the node id of its zone. However, it does this before
having checked whether the struct page pointer refers to a valid struct
page to begin with. This is guaranteed in most cases, but may not be
the case if CONFIG_HOLES_IN_ZONE=y.
So reorder the VM_BUG_ON() with the pfn_valid_within() check.
Link: http://lkml.kernel.org/r/1481706707-6211-2-git-send-email-ard.biesheuvel@linaro.org
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Yisheng Xie <xieyisheng1@huawei.com>
Cc: Robert Richter <rrichter@cavium.com>
Cc: James Morse <james.morse@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/mm_inline.h')
0 files changed, 0 insertions, 0 deletions