diff options
| author |   Eric Dumazet <edumazet@google.com> | 2021-11-19 07:43:31 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-11-22 12:49:42 +0000 |
| commit | 4b66d2161b8125b6caa6971815e85631cf3cf36f (patch) | |
| tree | 10eeca9981b607abc9fe4801577a1434826ddfa6 /include/linux/netdevice.h | |
| parent | Merge branch 'ethtool-copybreak' (diff) | |
| download | linux-dev-4b66d2161b8125b6caa6971815e85631cf3cf36f.tar.xz linux-dev-4b66d2161b8125b6caa6971815e85631cf3cf36f.zip | |
net: annotate accesses to dev->gso_max_size
dev->gso_max_size is written under RTNL protection, or when the device is
not yet visible, but is read locklessly.
Add the READ_ONCE()/WRITE_ONCE() pairs, and use netif_set_gso_max_size()
where we can to better document what is going on.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/netdevice.h')
| -rw-r--r-- | include/linux/netdevice.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cb7f2661d187..14eeb58ed197 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4731,7 +4731,8 @@ static inline bool netif_needs_gso(struct sk_buff *skb, static inline void netif_set_gso_max_size(struct net_device *dev, unsigned int size) { - dev->gso_max_size = size; + /* dev->gso_max_size is read locklessly from sk_setup_caps() */ + WRITE_ONCE(dev->gso_max_size, size); } static inline void skb_gso_error_unwind(struct sk_buff *skb, __be16 protocol, |