diff options
| author |   Gavin Shan <gwshan@linux.vnet.ibm.com> | 2014-05-21 15:23:30 +1000 |
|---|---|---|
| committer |   Bjorn Helgaas <bhelgaas@google.com> | 2014-05-27 17:10:16 -0600 |
| commit | d97ffe236894856d08146390ef3fbe6448a8ac2b (patch) | |
| tree | 0935d466ca429a5b61a9b82ed44a6c623175964f /include/linux/pci.h | |
| parent | PCI: Turn pcibios_penalize_isa_irq() into a weak function (diff) | |
| download | linux-dev-d97ffe236894856d08146390ef3fbe6448a8ac2b.tar.xz linux-dev-d97ffe236894856d08146390ef3fbe6448a8ac2b.zip | |
PCI: Fix return value from pci_user_{read,write}_config_*()
The PCI user-space config accessors pci_user_{read,write}_config_*() return
negative error numbers, which were introduced by commit 34e3207205ef
("PCI: handle positive error codes"). That patch converted all positive
error numbers from platform-specific PCI config accessors to -EINVAL, which
means the callers don't know anything about the specific cause of the
failure.
The patch fixes the issue by converting the positive PCIBIOS_* error values
to generic negative error numbers with pcibios_err_to_errno().
[bhelgaas: changelog]
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Greg Thelen <gthelen@google.com>
Diffstat (limited to 'include/linux/pci.h')
| -rw-r--r-- | include/linux/pci.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/pci.h b/include/linux/pci.h index 018877b8b4e8..322335aaa7e1 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -518,7 +518,7 @@ static inline int pcibios_err_to_errno(int err) case PCIBIOS_FUNC_NOT_SUPPORTED: return -ENOENT; case PCIBIOS_BAD_VENDOR_ID: - return -EINVAL; + return -ENOTTY; case PCIBIOS_DEVICE_NOT_FOUND: return -ENODEV; case PCIBIOS_BAD_REGISTER_NUMBER: @@ -529,7 +529,7 @@ static inline int pcibios_err_to_errno(int err) return -ENOSPC; } - return -ENOTTY; + return -ERANGE; } /* Low-level architecture-dependent routines */ |