diff options
| author |   Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-06-29 14:03:41 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-06-30 15:57:34 -0700 |
| commit | 8b11c20a658de159fcf18ebce4f2acfdf747ff25 (patch) | |
| tree | a108af20681fcab3ab87ff1dc44d1c2f262ec817 /include/linux/phy.h | |
| parent | Documentation: devres: add missing mdio helper (diff) | |
| download | linux-dev-8b11c20a658de159fcf18ebce4f2acfdf747ff25.tar.xz linux-dev-8b11c20a658de159fcf18ebce4f2acfdf747ff25.zip | |
phy: un-inline devm_mdiobus_register()
Functions should only be static inline if they're very short. This
devres helper is already over 10 lines and it will grow soon as we'll
be improving upon its approach. Pull it into mdio_devres.c.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/phy.h')
| -rw-r--r-- | include/linux/phy.h | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/include/linux/phy.h b/include/linux/phy.h index ecc7640705b9..7c75e1c90141 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -322,20 +322,9 @@ static inline struct mii_bus *mdiobus_alloc(void) } int __mdiobus_register(struct mii_bus *bus, struct module *owner); +int __devm_mdiobus_register(struct mii_bus *bus, struct module *owner); #define mdiobus_register(bus) __mdiobus_register(bus, THIS_MODULE) -static inline int devm_mdiobus_register(struct mii_bus *bus) -{ - int ret; - - if (!bus->is_managed) - return -EPERM; - - ret = mdiobus_register(bus); - if (!ret) - bus->is_managed_registered = 1; - - return ret; -} +#define devm_mdiobus_register(bus) __devm_mdiobus_register(bus, THIS_MODULE) void mdiobus_unregister(struct mii_bus *bus); void mdiobus_free(struct mii_bus *bus); |