diff options
| author |   Eric W. Biederman <ebiederm@xmission.com> | 2016-11-14 18:48:07 -0600 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2016-11-22 11:49:49 -0600 |
| commit | 64b875f7ac8a5d60a4e191479299e931ee949b67 (patch) | |
| tree | 0c913f705ae947f5903ca0ff91ed633d1c2adc4a /include/linux/ptrace.h | |
| parent | mm: Add a user_ns owner to mm_struct and fix ptrace permission checks (diff) | |
| download | linux-dev-64b875f7ac8a5d60a4e191479299e931ee949b67.tar.xz linux-dev-64b875f7ac8a5d60a4e191479299e931ee949b67.zip | |
ptrace: Capture the ptracer's creds not PT_PTRACE_CAP
When the flag PT_PTRACE_CAP was added the PTRACE_TRACEME path was
overlooked. This can result in incorrect behavior when an application
like strace traces an exec of a setuid executable.
Further PT_PTRACE_CAP does not have enough information for making good
security decisions as it does not report which user namespace the
capability is in. This has already allowed one mistake through
insufficient granulariy.
I found this issue when I was testing another corner case of exec and
discovered that I could not get strace to set PT_PTRACE_CAP even when
running strace as root with a full set of caps.
This change fixes the above issue with strace allowing stracing as
root a setuid executable without disabling setuid. More fundamentaly
this change allows what is allowable at all times, by using the correct
information in it's decision.
Cc: stable@vger.kernel.org
Fixes: 4214e42f96d4 ("v2.4.9.11 -> v2.4.9.12")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'include/linux/ptrace.h')
| -rw-r--r-- | include/linux/ptrace.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h index 504c98a278d4..e13bfdf7f314 100644 --- a/include/linux/ptrace.h +++ b/include/linux/ptrace.h @@ -19,7 +19,6 @@ #define PT_SEIZED 0x00010000 /* SEIZE used, enable new behavior */ #define PT_PTRACED 0x00000001 #define PT_DTRACE 0x00000002 /* delayed trace (used on m68k, i386) */ -#define PT_PTRACE_CAP 0x00000004 /* ptracer can follow suid-exec */ #define PT_OPT_FLAG_SHIFT 3 /* PT_TRACE_* event enable flags */ |