diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-03-31 12:58:56 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-31 23:25:39 -0400 |
| commit | e5d672a0780d9e7118caad4c171ec88b8299398d (patch) | |
| tree | 2d885d704df9eee43788e94bcac1142dd9b519fc /include/linux/rhashtable.h | |
| parent | ipv6: frags: rewrite ip6_expire_frag_queue() (diff) | |
| download | linux-dev-e5d672a0780d9e7118caad4c171ec88b8299398d.tar.xz linux-dev-e5d672a0780d9e7118caad4c171ec88b8299398d.zip | |
rhashtable: reorganize struct rhashtable layout
While under frags DDOS I noticed unfortunate false sharing between
@nelems and @params.automatic_shrinking
Move @nelems at the end of struct rhashtable so that first cache line
is shared between all cpus, because almost never dirtied.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/rhashtable.h')
| -rw-r--r-- | include/linux/rhashtable.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h index 668a21f04b09..1f8ad121eb43 100644 --- a/include/linux/rhashtable.h +++ b/include/linux/rhashtable.h @@ -152,25 +152,25 @@ struct rhashtable_params { /** * struct rhashtable - Hash table handle * @tbl: Bucket table - * @nelems: Number of elements in table * @key_len: Key length for hashfn - * @p: Configuration parameters * @max_elems: Maximum number of elements in table + * @p: Configuration parameters * @rhlist: True if this is an rhltable * @run_work: Deferred worker to expand/shrink asynchronously * @mutex: Mutex to protect current/future table swapping * @lock: Spin lock to protect walker list + * @nelems: Number of elements in table */ struct rhashtable { struct bucket_table __rcu *tbl; - atomic_t nelems; unsigned int key_len; - struct rhashtable_params p; unsigned int max_elems; + struct rhashtable_params p; bool rhlist; struct work_struct run_work; struct mutex mutex; spinlock_t lock; + atomic_t nelems; }; /** |