diff options
| author |   Willem de Bruijn <willemb@google.com> | 2016-06-24 16:02:35 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-06-28 09:08:51 -0400 |
| commit | 9a0fee2b552b1235fb1706ae1fc664ae74573be8 (patch) | |
| tree | 287669c8a80545d1b958e8f4426e155c7d3efe05 /include/linux | |
| parent | connector: fix out-of-order cn_proc netlink message delivery (diff) | |
| download | linux-dev-9a0fee2b552b1235fb1706ae1fc664ae74573be8.tar.xz linux-dev-9a0fee2b552b1235fb1706ae1fc664ae74573be8.zip | |
sock_diag: do not broadcast raw socket destruction
Diag intends to broadcast tcp_sk and udp_sk socket destruction.
Testing sk->sk_protocol for IPPROTO_TCP/IPPROTO_UDP alone is not
sufficient for this. Raw sockets can have the same type.
Add a test for sk->sk_type.
Fixes: eb4cb008529c ("sock_diag: define destruction multicast groups")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/sock_diag.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/linux/sock_diag.h b/include/linux/sock_diag.h index 4018b48f2b3b..a0596ca0e80a 100644 --- a/include/linux/sock_diag.h +++ b/include/linux/sock_diag.h @@ -36,6 +36,9 @@ enum sknetlink_groups sock_diag_destroy_group(const struct sock *sk) { switch (sk->sk_family) { case AF_INET: + if (sk->sk_type == SOCK_RAW) + return SKNLGRP_NONE; + switch (sk->sk_protocol) { case IPPROTO_TCP: return SKNLGRP_INET_TCP_DESTROY; @@ -45,6 +48,9 @@ enum sknetlink_groups sock_diag_destroy_group(const struct sock *sk) return SKNLGRP_NONE; } case AF_INET6: + if (sk->sk_type == SOCK_RAW) + return SKNLGRP_NONE; + switch (sk->sk_protocol) { case IPPROTO_TCP: return SKNLGRP_INET6_TCP_DESTROY; |