diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-03-31 12:58:51 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-31 23:25:39 -0400 |
| commit | 399d1404be660d355192ff4df5ccc3f4159ec1e4 (patch) | |
| tree | ca1e2d86cb32a06d91c35632ad19b5393be21a66 /include/net/inet_frag.h | |
| parent | inet: frags: remove some helpers (diff) | |
| download | linux-dev-399d1404be660d355192ff4df5ccc3f4159ec1e4.tar.xz linux-dev-399d1404be660d355192ff4df5ccc3f4159ec1e4.zip | |
inet: frags: get rif of inet_frag_evicting()
This refactors ip_expire() since one indentation level is removed.
Note: in the future, we should try hard to avoid the skb_clone()
since this is a serious performance cost.
Under DDOS, the ICMP message wont be sent because of rate limits.
Fact that ip6_expire_frag_queue() does not use skb_clone() is
disturbing too. Presumably IPv6 should have the same
issue than the one we fixed in commit ec4fbd64751d
("inet: frag: release spinlock before calling icmp_send()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/inet_frag.h')
| -rw-r--r-- | include/net/inet_frag.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index 4b5449df0aad..0e8e159d88f7 100644 --- a/include/net/inet_frag.h +++ b/include/net/inet_frag.h @@ -119,11 +119,6 @@ static inline void inet_frag_put(struct inet_frag_queue *q) inet_frag_destroy(q); } -static inline bool inet_frag_evicting(struct inet_frag_queue *q) -{ - return false; -} - /* Memory Tracking Functions. */ static inline int frag_mem_limit(struct netns_frags *nf) |