diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-20 09:50:14 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-22 12:06:17 +0100 |
| commit | 36eeee75ef0157e42fb6593dcc65daab289b559e (patch) | |
| tree | ffd982cc87508e5b1f36be5fa8bfeb96526dfbb5 /include/net/tcp.h | |
| parent | tcp: Fix a data-race around sysctl_tcp_app_win. (diff) | |
| download | linux-dev-36eeee75ef0157e42fb6593dcc65daab289b559e.tar.xz linux-dev-36eeee75ef0157e42fb6593dcc65daab289b559e.zip | |
tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
While reading sysctl_tcp_adv_win_scale, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/tcp.h')
| -rw-r--r-- | include/net/tcp.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/tcp.h b/include/net/tcp.h index 071735e10872..78a64e1b33a7 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1419,7 +1419,7 @@ void tcp_select_initial_window(const struct sock *sk, int __space, static inline int tcp_win_from_space(const struct sock *sk, int space) { - int tcp_adv_win_scale = sock_net(sk)->ipv4.sysctl_tcp_adv_win_scale; + int tcp_adv_win_scale = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_adv_win_scale); return tcp_adv_win_scale <= 0 ? (space>>(-tcp_adv_win_scale)) : |