diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-11-05 14:11:53 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-06 16:14:48 -0800 |
| commit | 288efe8606b62d0753ba6722b36ef241877251fd (patch) | |
| tree | 37cbacf02e504fafe20062ae25909a4ecfc4c807 /include/net | |
| parent | net: use helpers to change sk_ack_backlog (diff) | |
| download | linux-dev-288efe8606b62d0753ba6722b36ef241877251fd.tar.xz linux-dev-288efe8606b62d0753ba6722b36ef241877251fd.zip | |
net: annotate lockless accesses to sk->sk_ack_backlog
sk->sk_ack_backlog can be read without any lock being held.
We need to use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing
and/or potential KCSAN warnings.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/sock.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/net/sock.h b/include/net/sock.h index f2f853439b65..a126784aa7d9 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -859,17 +859,17 @@ static inline gfp_t sk_gfp_mask(const struct sock *sk, gfp_t gfp_mask) static inline void sk_acceptq_removed(struct sock *sk) { - sk->sk_ack_backlog--; + WRITE_ONCE(sk->sk_ack_backlog, sk->sk_ack_backlog - 1); } static inline void sk_acceptq_added(struct sock *sk) { - sk->sk_ack_backlog++; + WRITE_ONCE(sk->sk_ack_backlog, sk->sk_ack_backlog + 1); } static inline bool sk_acceptq_is_full(const struct sock *sk) { - return sk->sk_ack_backlog > sk->sk_max_ack_backlog; + return READ_ONCE(sk->sk_ack_backlog) > sk->sk_max_ack_backlog; } /* |