diff options
| author |   Mike Christie <michaelc@cs.wisc.edu> | 2008-01-31 13:36:53 -0600 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-02-07 18:02:37 -0600 |
| commit | 8b1d03434ee44b08c57f50403eaeab099facebf5 (patch) | |
| tree | 48d7c5aeb3b765284dcc3d8685ed6ea6aed350cb /include/scsi/libiscsi.h | |
| parent | [SCSI] iscsi: fix up iscsi printk prefix (diff) | |
| download | linux-dev-8b1d03434ee44b08c57f50403eaeab099facebf5.tar.xz linux-dev-8b1d03434ee44b08c57f50403eaeab099facebf5.zip | |
[SCSI] libiscsi: fix session age rollover and remove cid encoding
The session age mask is only 4 bits, but session->age is 32. When
it gets larger then 15 and we try to or the bits some bits get
dropped and the check for session age in iscsi_verify_itt is useless.
The ISCSI_CID_MASK related bits are also useless since cid is always
one.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'include/scsi/libiscsi.h')
| -rw-r--r-- | include/scsi/libiscsi.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/scsi/libiscsi.h b/include/scsi/libiscsi.h index 5784e4ff8edc..7b90b63fb5c7 100644 --- a/include/scsi/libiscsi.h +++ b/include/scsi/libiscsi.h @@ -70,8 +70,6 @@ enum { #define ISCSI_SUSPEND_BIT 1 #define ISCSI_ITT_MASK (0xfff) -#define ISCSI_CID_SHIFT 12 -#define ISCSI_CID_MASK (0xffff << ISCSI_CID_SHIFT) #define ISCSI_AGE_SHIFT 28 #define ISCSI_AGE_MASK (0xf << ISCSI_AGE_SHIFT) |