diff options
| author |   Ming Lei <ming.lei@redhat.com> | 2021-11-09 15:11:43 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2021-11-09 08:14:27 -0700 |
| commit | 93542fbfa7b726d053c01a9399577c03968c4f6b (patch) | |
| tree | 8c51175536212413500e304da07ad81fb1ec19b8 /include/scsi/scsi_device.h | |
| parent | scsi: avoid to quiesce sdev->request_queue two times (diff) | |
| download | linux-dev-93542fbfa7b726d053c01a9399577c03968c4f6b.tar.xz linux-dev-93542fbfa7b726d053c01a9399577c03968c4f6b.zip | |
scsi: make sure that request queue queiesce and unquiesce balanced
For fixing queue quiesce race between driver and block layer(elevator
switch, update nr_requests, ...), we need to support concurrent quiesce
and unquiesce, which requires the two call balanced.
It isn't easy to audit that in all scsi drivers, especially the two may
be called from different contexts, so do it in scsi core with one
per-device atomic variable to balance quiesce and unquiesce.
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Fixes: e70feb8b3e68 ("blk-mq: support concurrent queue quiesce/unquiesce")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20211109071144.181581-4-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/scsi/scsi_device.h')
| -rw-r--r-- | include/scsi/scsi_device.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 430b73bd02ac..d1c6fc83b1e3 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -207,6 +207,7 @@ struct scsi_device { * creation time */ unsigned ignore_media_change:1; /* Ignore MEDIA CHANGE on resume */ + unsigned int queue_stopped; /* request queue is quiesced */ bool offline_already; /* Device offline message logged */ atomic_t disk_events_disable_depth; /* disable depth for disk events */ |