diff options
| author |   Matthew Wilcox <matthew@wil.cx> | 2007-09-25 12:42:04 -0400 |
|---|---|---|
| committer |   James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:52:46 -0400 |
| commit | 6f5391c283d7fdcf24bf40786ea79061919d1e1d (patch) | |
| tree | 32ee9abddf9879445792019e1c03bcd28ce6bd4f /include/scsi/scsi_driver.h | |
| parent | [SCSI] gdth: Stop abusing ->done for internal commands (diff) | |
| download | linux-dev-6f5391c283d7fdcf24bf40786ea79061919d1e1d.tar.xz linux-dev-6f5391c283d7fdcf24bf40786ea79061919d1e1d.zip | |
[SCSI] Get rid of scsi_cmnd->done
The ULD ->done callback moves into the scsi_driver. By moving the call
to scsi_io_completion() from scsi_blk_pc_done() to scsi_finish_command(),
we can eliminate the latter entirely. By returning 'good_bytes' from
the ->done callback (rather than invoking scsi_io_completion()), we can
stop exporting scsi_io_completion().
Also move the prototypes from sd.h to sd.c as they're all internal anyway.
Rename sd_rw_intr to sd_done and rw_intr to sr_done.
Inspired-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'include/scsi/scsi_driver.h')
| -rw-r--r-- | include/scsi/scsi_driver.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h index 56a304709fde..1f5ca7f62116 100644 --- a/include/scsi/scsi_driver.h +++ b/include/scsi/scsi_driver.h @@ -15,6 +15,7 @@ struct scsi_driver { struct device_driver gendrv; void (*rescan)(struct device *); + int (*done)(struct scsi_cmnd *); }; #define to_scsi_driver(drv) \ container_of((drv), struct scsi_driver, gendrv) |