diff options
| author |   Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2021-01-26 17:17:48 +0000 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-01-27 13:06:51 +0000 |
| commit | 1da0b9899abdbc7103d3ec6b1a888efda41dbb59 (patch) | |
| tree | fb681f7b0d04203d09d4e10e7ea42248a04101a7 /include/sound/soc-component.h | |
| parent | ASoC: tegra: ahub: Reset hardware properly (diff) | |
| download | linux-dev-1da0b9899abdbc7103d3ec6b1a888efda41dbb59.tar.xz linux-dev-1da0b9899abdbc7103d3ec6b1a888efda41dbb59.zip | |
ASoC: soc-component: add snd_soc_component_read/write_field()
It's often the case that we would write or read a particular field
in register. With the current soc_component apis, reading a particular
field in register would involve first read the register and then
perform shift operations.
Ex:
to read from a field mask of 0xf0
val = snd_soc_component_read(component, reg);
field = ((val & 0xf0) >> 0x4);
This is sometimes prone to errors and code become less readable!
With this new api we could just do
field = snd_soc_component_read_field(component, reg, 0xf0);
this makes it bit simple, easy to write and less error prone!
This also applies to writing!
There are various places in kernel which provides such field interfaces
however soc_component seems to be missing this.
This patch is inspired by FIELD_GET/FIELD_PREP macros in include/linux/bitfield.h
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210126171749.1863-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include/sound/soc-component.h')
| -rw-r--r-- | include/sound/soc-component.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h index 0bce41fefd30..5b47768222b7 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -353,6 +353,12 @@ int snd_soc_component_test_bits(struct snd_soc_component *component, unsigned int reg, unsigned int mask, unsigned int value); +unsigned int snd_soc_component_read_field(struct snd_soc_component *component, + unsigned int reg, unsigned int mask); +int snd_soc_component_write_field(struct snd_soc_component *component, + unsigned int reg, unsigned int mask, + unsigned int val); + /* component wide operations */ int snd_soc_component_set_sysclk(struct snd_soc_component *component, int clk_id, int source, |