diff options
| author |   Cezary Rojewski <cezary.rojewski@intel.com> | 2022-07-06 14:02:26 +0200 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2022-07-15 16:26:50 +0200 |
| commit | e7255c00b10e5e570dd8eb24f59e964eeec38d3b (patch) | |
| tree | 683616d9489b7085e3454a3233ef116eb486411d /include/sound | |
| parent | ALSA: hda: cs35l41: Add module parameter to control firmware load (diff) | |
| download | linux-dev-e7255c00b10e5e570dd8eb24f59e964eeec38d3b.tar.xz linux-dev-e7255c00b10e5e570dd8eb24f59e964eeec38d3b.zip | |
ALSA: hda: Skip event processing for unregistered codecs
When codec is unbound but not yet removed, in the eyes of
snd_hdac_bus_process_unsol_events() it is still a valid target to
delegate work to. Such behaviour may lead to use-after-free errors.
Address by verifying if codec is actually registered.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20220706120230.427296-6-cezary.rojewski@intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound')
| -rw-r--r-- | include/sound/hda_codec.h | 1 | ||||
| -rw-r--r-- | include/sound/hdaudio.h | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/include/sound/hda_codec.h b/include/sound/hda_codec.h index b7be300b6b18..6d3c82c4b6ac 100644 --- a/include/sound/hda_codec.h +++ b/include/sound/hda_codec.h @@ -231,7 +231,6 @@ struct hda_codec { /* misc flags */ unsigned int configured:1; /* codec was configured */ unsigned int in_freeing:1; /* being released */ - unsigned int registered:1; /* codec was registered */ unsigned int display_power_control:1; /* needs display power */ unsigned int spdif_status_reset :1; /* needs to toggle SPDIF for each * status change diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h index 15f15075238d..797bf67a164d 100644 --- a/include/sound/hdaudio.h +++ b/include/sound/hdaudio.h @@ -93,6 +93,7 @@ struct hdac_device { bool lazy_cache:1; /* don't wake up for writes */ bool caps_overwriting:1; /* caps overwrite being in process */ bool cache_coef:1; /* cache COEF read/write too */ + unsigned int registered:1; /* codec was registered */ }; /* device/driver type used for matching */ |