diff options
| author |   Daniel Borkmann <daniel@iogearbox.net> | 2016-03-18 18:37:59 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-20 13:44:34 -0400 |
| commit | 69716a2b51aeb68fe295c0d09e26c8781eacebde (patch) | |
| tree | dea003dce3acd0e36e5a248b49fd159a8c76845f /include/trace | |
| parent | geneve: fix populating tclass in geneve_get_v6_dst (diff) | |
| download | linux-dev-69716a2b51aeb68fe295c0d09e26c8781eacebde.tar.xz linux-dev-69716a2b51aeb68fe295c0d09e26c8781eacebde.zip | |
ipv6, trace: fix tos reporting on fib6_table_lookup
flowi6_tos of struct flowi6 is unused in IPv6, therefore dumping tos on
that tracepoint will also give incorrect information wrt traffic class.
If we want to fix it, we need to extract it via ip6_tclass(flp->flowlabel).
While for the same test case I get a count of 0 non-zero tos values before
the change, they now start to show up after the change:
# ./perf record -e fib6:fib6_table_lookup -a sleep 10
# ./perf script | grep -v "tos 0" | wc -l
60
Since there's no user in the kernel tree anymore of flowi6_tos, remove the
define to avoid any future confusion on this.
Fixes: b811580d91e9 ("net: IPv6 fib lookup tracepoint")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/trace')
| -rw-r--r-- | include/trace/events/fib6.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/trace/events/fib6.h b/include/trace/events/fib6.h index 4cf6bac4686d..d60096cddb2a 100644 --- a/include/trace/events/fib6.h +++ b/include/trace/events/fib6.h @@ -37,7 +37,7 @@ TRACE_EVENT(fib6_table_lookup, __entry->tb_id = tb_id; __entry->oif = flp->flowi6_oif; __entry->iif = flp->flowi6_iif; - __entry->tos = flp->flowi6_tos; + __entry->tos = ip6_tclass(flp->flowlabel); __entry->scope = flp->flowi6_scope; __entry->flags = flp->flowi6_flags; |