diff options
author | Eric Dumazet <edumazet@google.com> | 2021-11-30 19:32:46 -0800 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-01 19:06:09 -0800 |
commit | ce8299b6f76f28326fedce2b4da90888bd97eab2 (patch) | |
tree | ee9c848444134a92a77dfab024e3c7b6c14183e2 /include/uapi | |
parent | net: mvneta: program 1ms autonegotiation clock divisor (diff) | |
download | linux-dev-ce8299b6f76f28326fedce2b4da90888bd97eab2.tar.xz linux-dev-ce8299b6f76f28326fedce2b4da90888bd97eab2.zip |
Revert "net: snmp: add statistics for tcp small queue check"
This reverts commit aeeecb889165617a841e939117f9a8095d0e7d80.
The new SNMP variable (TCPSmallQueueFailure) can be incremented
for good reasons, even on a 100Gbit single TCP_STREAM flow.
If we really wanted to ease driver debugging [1], this would
require something more sophisticated.
[1] Usually, if a driver is delaying TX completions too much,
this can lead to stalls in TCP output. Various work arounds
have been used in the past, like skb_orphan() in ndo_start_xmit().
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Menglong Dong <imagedong@tencent.com>
Link: https://lore.kernel.org/r/20211201033246.2826224-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/uapi')
-rw-r--r-- | include/uapi/linux/snmp.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h index e32ec6932e82..904909d020e2 100644 --- a/include/uapi/linux/snmp.h +++ b/include/uapi/linux/snmp.h @@ -292,7 +292,6 @@ enum LINUX_MIB_TCPDSACKIGNOREDDUBIOUS, /* TCPDSACKIgnoredDubious */ LINUX_MIB_TCPMIGRATEREQSUCCESS, /* TCPMigrateReqSuccess */ LINUX_MIB_TCPMIGRATEREQFAILURE, /* TCPMigrateReqFailure */ - LINUX_MIB_TCPSMALLQUEUEFAILURE, /* TCPSmallQueueFailure */ __LINUX_MIB_MAX }; |