diff options
| author |   Russell King <rmk+lkml@arm.linux.org.uk> | 2006-10-22 15:57:18 +0100 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-23 11:01:33 -0700 |
| commit | 04fed361dadb7921507a470947ac23d2f26352cf (patch) | |
| tree | 32ba7e6c1f75159914dd3311e1cdc4243a84de27 /include | |
| parent | Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/perex/alsa (diff) | |
| download | linux-dev-04fed361dadb7921507a470947ac23d2f26352cf.tar.xz linux-dev-04fed361dadb7921507a470947ac23d2f26352cf.zip | |
[PATCH] Remove __must_check for device_for_each_child()
Eliminate more __must_check madness.
The return code from device_for_each_child() depends on the values
which the helper function returns. If the helper function always
returns zero, it's utterly pointless to check the return code from
device_for_each_child().
The only code which knows if the return value should be checked is
the caller itself, so forcing the return code to always be checked
is silly. Hence, remove the __must_check annotation.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/device.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/device.h b/include/linux/device.h index 662e6a10144e..9d4f6a963936 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -393,7 +393,7 @@ extern void device_unregister(struct device * dev); extern void device_initialize(struct device * dev); extern int __must_check device_add(struct device * dev); extern void device_del(struct device * dev); -extern int __must_check device_for_each_child(struct device *, void *, +extern int device_for_each_child(struct device *, void *, int (*fn)(struct device *, void *)); extern int device_rename(struct device *dev, char *new_name); |