diff options
| author |   Ursula Braun <ubraun@linux.ibm.com> | 2019-04-11 11:17:32 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-04-11 11:04:08 -0700 |
| commit | 07603b230895a74ebb1e2a1231ac45c29c2a8cd3 (patch) | |
| tree | b4c1ee2e7ca061a7b37f16bdd302297bf27aaea4 /include | |
| parent | net/smc: fix a NULL pointer dereference (diff) | |
| download | linux-dev-07603b230895a74ebb1e2a1231ac45c29c2a8cd3.tar.xz linux-dev-07603b230895a74ebb1e2a1231ac45c29c2a8cd3.zip | |
net/smc: propagate file from SMC to TCP socket
fcntl(fd, F_SETOWN, getpid()) selects the recipient of SIGURG signals
that are delivered when out-of-band data arrives on socket fd.
If an SMC socket program makes use of such an fcntl() call, it fails
in case of fallback to TCP-mode. In case of fallback the traffic is
processed with the internal TCP socket. Propagating field "file" from the
SMC socket to the internal TCP socket fixes the issue.
Reviewed-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/sock.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/include/net/sock.h b/include/net/sock.h index 8de5ee258b93..341f8bafa0cf 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -2084,12 +2084,6 @@ static inline bool skwq_has_sleeper(struct socket_wq *wq) * @p: poll_table * * See the comments in the wq_has_sleeper function. - * - * Do not derive sock from filp->private_data here. An SMC socket establishes - * an internal TCP socket that is used in the fallback case. All socket - * operations on the SMC socket are then forwarded to the TCP socket. In case of - * poll, the filp->private_data pointer references the SMC socket because the - * TCP socket has no file assigned. */ static inline void sock_poll_wait(struct file *filp, struct socket *sock, poll_table *p) |