diff options
| author |   H. Peter Anvin <hpa@linux.intel.com> | 2014-02-13 07:46:04 -0800 |
|---|---|---|
| committer | H. Peter Anvin <hpa@linux.intel.com> | 2014-02-13 08:40:52 -0800 |
| commit | 4640c7ee9b8953237d05a61ea3ea93981d1bc961 (patch) | |
| tree | 580aa78183348a9cfcea51a50b1cc4e8ef5a309f /include | |
| parent | x86, smap: Don't enable SMAP if CONFIG_X86_SMAP is disabled (diff) | |
| download | linux-dev-4640c7ee9b8953237d05a61ea3ea93981d1bc961.tar.xz linux-dev-4640c7ee9b8953237d05a61ea3ea93981d1bc961.zip | |
x86, smap: smap_violation() is bogus if CONFIG_X86_SMAP is off
If CONFIG_X86_SMAP is disabled, smap_violation() tests for conditions
which are incorrect (as the AC flag doesn't matter), causing spurious
faults.
The dynamic disabling of SMAP (nosmap on the command line) is fine
because it disables X86_FEATURE_SMAP, therefore causing the
static_cpu_has() to return false.
Found by Fengguang Wu's test system.
[ v3: move all predicates into smap_violation() ]
[ v2: use IS_ENABLED() instead of #ifdef ]
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Link: http://lkml.kernel.org/r/20140213124550.GA30497@localhost
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: <stable@vger.kernel.org> # v3.7+
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions