diff options
| author |   Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2016-04-06 11:55:05 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-04-08 16:50:41 -0400 |
| commit | 4d5770b39710180644f655b2c6cb0c880d108c63 (patch) | |
| tree | a416797b924cb52dfe9fe95464f12205286e7bc7 /include | |
| parent | net: dsa: make the FDB add function return void (diff) | |
| download | linux-dev-4d5770b39710180644f655b2c6cb0c880d108c63.tar.xz linux-dev-4d5770b39710180644f655b2c6cb0c880d108c63.zip | |
net: dsa: make the VLAN add function return void
The switchdev design implies that a software error should not happen in
the commit phase since it must have been previously reported in the
prepare phase. If an hardware error occurs during the commit phase,
there is nothing switchdev can do about it.
The DSA layer separates port_vlan_prepare and port_vlan_add for
simplicity and convenience. If an hardware error occurs during the
commit phase, there is no need to report it outside the driver itself.
Make the DSA port_vlan_add routine return void for explicitness.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/dsa.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/dsa.h b/include/net/dsa.h index f1670a4daaeb..18d1be3ad62d 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -310,7 +310,7 @@ struct dsa_switch_driver { int (*port_vlan_prepare)(struct dsa_switch *ds, int port, const struct switchdev_obj_port_vlan *vlan, struct switchdev_trans *trans); - int (*port_vlan_add)(struct dsa_switch *ds, int port, + void (*port_vlan_add)(struct dsa_switch *ds, int port, const struct switchdev_obj_port_vlan *vlan, struct switchdev_trans *trans); int (*port_vlan_del)(struct dsa_switch *ds, int port, |