diff options
| author | 2013-05-21 11:36:30 -0300 | |
|---|---|---|
| committer | 2013-05-21 12:04:16 -0300 | |
| commit | 6a084d6b3dc200b855ae8a3c6771abe285a3835d (patch) | |
| tree | bb4c91ccd65039088c41d49997a83a3e895ccab2 /include | |
| parent | [media] videobuf-dma-contig: use vm_iomap_memory() (diff) | |
[media] saa7115: Don't use a dynamic array
At least on s390, gcc complains about that:
drivers/media/i2c/saa7115.c: In function 'saa711x_detect_chip.constprop.2':
drivers/media/i2c/saa7115.c:1647:1: warning: 'saa711x_detect_chip.constprop.2' uses dynamic stack allocation [enabled by default]
While for me the above report seems utterly bogus, as the
compiler should be optimizing saa711x_detect_chip, merging
it with saa711x_detect_chip and changing:
char chip_ver[size - 1];
to
char chip_ver[16];
because this function is only called on this code snippet:
char name[17];
...
ident = saa711x_detect_chip(client, id, name, sizeof(name));
It seems that gcc is not optimizing it, at least on s390.
As getting rid of it is easy, let's do it.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
