diff options
| author |   Krzysztof Opasiak <k.opasiak@samsung.com> | 2016-12-20 19:52:16 +0100 |
|---|---|---|
| committer |   Felipe Balbi <felipe.balbi@linux.intel.com> | 2017-01-02 10:55:28 +0200 |
| commit | 7e4da3fcf7c9fe042f2f7cb7bf23861a899b4a8f (patch) | |
| tree | d29bc543131edce31c5ac39040feee02000eea3d /include | |
| parent | usb: dwc3: pci: Fix dr_mode misspelling (diff) | |
| download | linux-dev-7e4da3fcf7c9fe042f2f7cb7bf23861a899b4a8f.tar.xz linux-dev-7e4da3fcf7c9fe042f2f7cb7bf23861a899b4a8f.zip | |
usb: gadget: composite: Test get_alt() presence instead of set_alt()
By convention (according to doc) if function does not provide
get_alt() callback composite framework should assume that it has only
altsetting 0 and should respond with error if host tries to set
other one.
After commit dd4dff8b035f ("USB: composite: Fix bug: should test
set_alt function pointer before use it")
we started checking set_alt() callback instead of get_alt().
This check is useless as we check if set_alt() is set inside
usb_add_function() and fail if it's NULL.
Let's fix this check and move comment about why we check the get
method instead of set a little bit closer to prevent future false
fixes.
Fixes: dd4dff8b035f ("USB: composite: Fix bug: should test set_alt function pointer before use it")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions