diff options
| author |   Michael S. Tsirkin <mst@redhat.com> | 2021-11-24 18:44:17 -0500 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2021-11-24 18:47:27 -0500 |
| commit | f124034faa911ed534bf8c4881ad98dbbde2a966 (patch) | |
| tree | cc0a023f2be14b3a30c748cef70318f0531c4dc0 /include | |
| parent | Revert "virtio-net: don't let virtio core to validate used length" (diff) | |
| download | linux-dev-f124034faa911ed534bf8c4881ad98dbbde2a966.tar.xz linux-dev-f124034faa911ed534bf8c4881ad98dbbde2a966.zip | |
Revert "virtio_ring: validate used buffer length"
This reverts commit 939779f5152d161b34f612af29e7dc1ac4472fcf.
Attempts to validate length in the core did not work out: there turn out
to exist multiple broken devices, and in particular legacy devices are
known to be broken in this respect.
We have ideas for handling this better in the next version but for now
let's revert to a known good state to make sure drivers work for people.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/virtio.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 44d0e09da2d9..41edbc01ffa4 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -152,7 +152,6 @@ size_t virtio_max_dma_size(struct virtio_device *vdev); * @feature_table_size: number of entries in the feature table array. * @feature_table_legacy: same as feature_table but when working in legacy mode. * @feature_table_size_legacy: number of entries in feature table legacy array. - * @suppress_used_validation: set to not have core validate used length * @probe: the function to call when a device is found. Returns 0 or -errno. * @scan: optional function to call after successful probe; intended * for virtio-scsi to invoke a scan. @@ -169,7 +168,6 @@ struct virtio_driver { unsigned int feature_table_size; const unsigned int *feature_table_legacy; unsigned int feature_table_size_legacy; - bool suppress_used_validation; int (*validate)(struct virtio_device *dev); int (*probe)(struct virtio_device *dev); void (*scan)(struct virtio_device *dev); |