diff options
| author |   Denis Efremov <efremov@ispras.ru> | 2019-07-12 21:55:21 +0300 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-17 14:45:49 -0700 |
| commit | 5635f897ed83fd539df78e98ba69ee91592f9bb8 (patch) | |
| tree | cc7a5fc94670775c0fb7c8e556c9079b08b9f7cd /init | |
| parent | floppy: fix div-by-zero in setup_format_params (diff) | |
| download | linux-dev-5635f897ed83fd539df78e98ba69ee91592f9bb8.tar.xz linux-dev-5635f897ed83fd539df78e98ba69ee91592f9bb8.zip | |
floppy: fix out-of-bounds read in next_valid_format
This fixes a global out-of-bounds read access in the next_valid_format
function of the floppy driver.
The values from autodetect field of the struct floppy_drive_params are
used as indices for the floppy_type array in the next_valid_format
function 'floppy_type[DP->autodetect[probed_format]].sect'.
To trigger the bug, one could use a value out of range and set the drive
parameters with the FDSETDRVPRM ioctl. A floppy disk is not required to
be inserted.
CAP_SYS_ADMIN is required to call FDSETDRVPRM.
The patch adds the check for values of the autodetect field to be in the
'0 <= x < ARRAY_SIZE(floppy_type)' range of the floppy_type array indices.
The bug was found by syzkaller.
Signed-off-by: Denis Efremov <efremov@ispras.ru>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions