diff options
| author |   Petr Mladek <pmladek@suse.com> | 2019-06-11 16:13:20 +0200 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2019-06-20 16:19:13 +0200 |
| commit | ac59a471e9371e3184425efd6a2fd8ac5c7e4c2b (patch) | |
| tree | 903415ac7d0f4d408f002dbca75002a0cfd3f7c9 /kernel/livepatch | |
| parent | Revert "livepatch: Remove reliable stacktrace check in klp_try_switch_task()" (diff) | |
| download | linux-dev-ac59a471e9371e3184425efd6a2fd8ac5c7e4c2b.tar.xz linux-dev-ac59a471e9371e3184425efd6a2fd8ac5c7e4c2b.zip | |
livepatch: Remove duplicate warning about missing reliable stacktrace support
WARN_ON_ONCE() could not be called safely under rq lock because
of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in
klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return
-ENOSYS thanks to klp_have_reliable_stack() check in
klp_try_switch_task().
[ mbenes: changelog edited ]
Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'kernel/livepatch')
| -rw-r--r-- | kernel/livepatch/transition.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c index cb85dae09ce5..3c764e73b032 100644 --- a/kernel/livepatch/transition.c +++ b/kernel/livepatch/transition.c @@ -259,7 +259,6 @@ static int klp_check_stack(struct task_struct *task, char *err_buf) int ret, nr_entries; ret = stack_trace_save_tsk_reliable(task, entries, ARRAY_SIZE(entries)); - WARN_ON_ONCE(ret == -ENOSYS); if (ret < 0) { snprintf(err_buf, STACK_ERR_BUF_SIZE, "%s: %s:%d has an unreliable stack\n", |